Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(24.04): Add JQ slices #116

Merged
merged 8 commits into from
May 16, 2024
Merged

feat(24.04): Add JQ slices #116

merged 8 commits into from
May 16, 2024

Conversation

SamirPS
Copy link

@SamirPS SamirPS commented Feb 2, 2024

This PR add the libs and the jq slices for noble

i have one issue with last version of chisel

chisel cut --release chisel-releases/ --root test/ jq_bins
2024/02/02 15:17:42 Processing chisel-releases/ release...
error: invalid slice definition filename: "jq.yaml"")

Signed_Off_By: Samir Akarioh [email protected]

lwnexgen
lwnexgen reviewed Feb 2, 2024
View reviewed changes
slices/libjq1.yaml Outdated Show resolved Hide resolved
lwnexgen
lwnexgen reviewed Feb 2, 2024
View reviewed changes
slices/libonig5.yaml Outdated Show resolved Hide resolved
lwnexgen
lwnexgen approved these changes Feb 2, 2024
View reviewed changes
Copy link

@lwnexgen lwnexgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any reason this couldn't get backported to 22.04 (and presumably 23.10) as well?

@SamirPS
Copy link
Author

SamirPS commented Feb 2, 2024

He can be backported, for now i have just done it for noble

@rebornplusplus rebornplusplus mentioned this pull request Feb 5, 2024
Closed
@rebornplusplus
Copy link
Member

rebornplusplus commented Feb 5, 2024 •
edited
Loading

Hi Samir. 😉 This will need to wait on canonical/chisel#119.

@rebornplusplus rebornplusplus self-assigned this Feb 5, 2024
@rebornplusplus rebornplusplus added the Blocked Waiting for something external label Feb 5, 2024
@rebornplusplus rebornplusplus removed the Blocked Waiting for something external label Mar 15, 2024
rebornplusplus
rebornplusplus requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer blocked by Chisel since v0.9.1 was released recently.

The PR looks okay to me. Left only a couple of comments, everything else looks good.

slices/libonig5.yaml Outdated Show resolved Hide resolved
slices/libjq1.yaml Outdated Show resolved Hide resolved
SamirPS and others added 2 commits March 18, 2024 09:08
@SamirPS
feat(24.04): Add JQ slices
7f801af 
This PR add the libs and the jq slices for noble

Signed_Off_By: Samir Akarioh <[email protected]>
@SamirPS
Fix the path for slice
a3d93bc
@github-actions GitHub Actions
Copy link

Diff of dependencies:
None found.

rebornplusplus
rebornplusplus approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Samir. Thanks a bunch!

This will need another maintainer's approval to be merged, but everyone else is on holiday until April first week. We can merge it then. Until then, please feel free to backport this for other active releases.

cjdcordeiro
cjdcordeiro requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, the cla seems to be failing. maybe because of the new email address?

@SamirPS
Copy link
Author

SamirPS commented Apr 4, 2024 •
edited
Loading

Hey, I just signed the CLA normally, can you trigger the action?

@SamirPS SamirPS requested a review from cjdcordeiro April 4, 2024 11:31
@cjdcordeiro
Copy link
Collaborator

just did, still no good

@SamirPS
Copy link
Author

SamirPS commented Apr 4, 2024

oh I see, I need to add my email to my launchpad account. I will do it this week or beginning of next week.

@SamirPS
Copy link
Author

SamirPS commented Apr 4, 2024

Hey,

Can you retry the cla check action ? I just added my email to launchpad

@rebornplusplus
Copy link
Member

Hey,

Can you retry the cla check action ? I just added my email to launchpad

Hiya, re-tried the job. It's asking for the Yahoo email too apparently.

Checking the following users on Launchpad:

  • a*****@yahoo.com ✕ (has not signed the CLA)

@SamirPS
Copy link
Author

SamirPS commented Apr 5, 2024 •
edited
Loading

I have just sign the cla : https://ubuntu.com/legal/contributors with the email: [email protected] and launchpad account samiraka

@SamirPS
Copy link
Author

SamirPS commented Apr 5, 2024

hum, something is weird in my setup i guess but don't know what

@rebornplusplus
Copy link
Member

CLA is passing now, thanks!

@SamirPS
Copy link
Author

SamirPS commented May 16, 2024

You can merge it 🚀

cjdcordeiro
cjdcordeiro approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @SamirPS ;)

@cjdcordeiro cjdcordeiro merged commit 8f8d68c into canonical:ubuntu-24.04 May 16, 2024
12 checks passed
@SamirPS SamirPS deleted the ubuntu-24.04 branch May 16, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwnexgen lwnexgen lwnexgen approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@rebornplusplus rebornplusplus rebornplusplus approved these changes

Assignees

@cjdcordeiro cjdcordeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamirPS @rebornplusplus @cjdcordeiro @lwnexgen @letFunny