Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(20.04): add lint job #177

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

rebornplusplus
Copy link
Member

Proposed changes

This PR adds a "Lint" job to lint the slices and chisel.yaml.

Forward porting

Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will wait for the same as in #147 (comment)

@rebornplusplus rebornplusplus linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of them. Thanks. LGTM

@cjdcordeiro cjdcordeiro self-assigned this Mar 8, 2024
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cjdcordeiro cjdcordeiro merged commit f7268fe into canonical:ubuntu-20.04 Mar 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linting issues in existing slices
3 participants