Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow to check package dependencies #187

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

rebornplusplus
Copy link
Member

@rebornplusplus rebornplusplus commented Mar 12, 2024

Proposed changes

This PR adds a new reusable workflow which can be run on Pull Requests to see if the packages listed in "essential" of a slice are the true dependencies of the slice package. This workflow will add a PR comment if it finds any errors.

Related issues/PRs

#188

Testing

See demo at rebornplusplus#9.

Checklist

This commit adds a new reusable workflow which can be run on Pull
Requests to see if the packages listed in "essential" of a slice are the
true dependencies of the slice package. This workflow will add a PR
comment if it finds any errors.
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking really nice. I think all comments are purely about refactoring and aesthetics.

.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro self-assigned this Mar 12, 2024
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Mar 12, 2024
@rebornplusplus
Copy link
Member Author

Note that this PR is running the "Install Slices" tests. Raised #192 to remove them.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
.github/workflows/pkg-deps.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@cjdcordeiro cjdcordeiro merged commit b00b6e7 into canonical:main Mar 13, 2024
1 check passed
gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 24, 2024
This commit adds a new reusable workflow which can be run on Pull
Requests to see if the packages listed in "essential" of a slice are the
true dependencies of the slice package. This workflow will add a PR
comment if it finds any errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants