-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(22.04): bump format to v1 #195
feat(22.04): bump format to v1 #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rebornplusplus the pkg coverage is failing: https://github.com/canonical/chisel-releases/actions/runs/8297308411/job/22710112677 |
Diff of dependencies: |
fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@rebornplusplus does it look good to you? (since this is the most used release, I just want to triple check) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Chisel >= v0.9.0 should work well with this. Thanks!
Proposed changes
Same as #194
Forward porting
#194
#193
Checklist