Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(22.04): bump format to v1 #195

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

Proposed changes

Same as #194

Forward porting

#194
#193

Checklist

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@cjdcordeiro cjdcordeiro mentioned this pull request Mar 14, 2024
2 tasks
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjdcordeiro
Copy link
Collaborator Author

Copy link

Diff of dependencies:
None found.


@cjdcordeiro
Copy link
Collaborator Author

Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cjdcordeiro
Copy link
Collaborator Author

@rebornplusplus does it look good to you? (since this is the most used release, I just want to triple check)

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Chisel >= v0.9.0 should work well with this. Thanks!

@cjdcordeiro cjdcordeiro merged commit 09254d3 into canonical:ubuntu-22.04 Apr 4, 2024
12 checks passed
@cjdcordeiro cjdcordeiro deleted the feat/format-v1 branch April 4, 2024 16:18
gregory-schiano pushed a commit to gregory-schiano/chisel-releases that referenced this pull request Jun 22, 2024
cjdcordeiro added a commit to ozanmakes/chisel-releases that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants