Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add ffmpeg dependencies slices #328

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

HadrienPatte
Copy link
Contributor

Proposed changes

The overall goal is to create a SDF for the ffmpeg package. Since ffmpeg has a pretty deep dependency tree, this is broken up in a series of smaller PRs (see #326, #297 and #252). This PR adds SDF for the following packages that are all transitive dependencies of ffmpeg:

  • libcdio-cdda2t64
  • libcdio-paranoia2t64
  • libnorm1t64
  • libxcb-dri2-0
  • libxcb-dri3-0
  • libxcb-glx0
  • libxcb-present0
  • libxcb-randr0
  • libxcb-render0
  • libxcb-shape0
  • libxcb-shm0
  • libxcb-sync1
  • libxcb-xfixes0
  • libxcb1
  • libxdmcp6
  • libzimg2
  • libzmq5

Related issues/PRs

Followup of #326, #297 and #252

Forward porting

Checklist

Additional Context

Copy link

github-actions bot commented Aug 30, 2024

Diff of dependencies:

slices/libcdio-cdda2t64.yaml
@@ -1,2 +1,2 @@
 libc6
-libcdio19
+libcdio19t64
slices/libcdio-paranoia2t64.yaml
@@ -1,3 +1,3 @@
 libc6
 libcdio-cdda2t64
-libcdio19
+libcdio19t64
slices/libzmq5.yaml
@@ -3,6 +3,6 @@
 libgcc-s1
 libgssapi-krb5-2
 libnorm1t64
-libpgm-5.3-0
+libpgm-5.3-0t64
 libsodium23
 libstdc++6

@HadrienPatte HadrienPatte marked this pull request as draft August 30, 2024 12:02
@HadrienPatte HadrienPatte marked this pull request as ready for review August 30, 2024 13:00
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

When slicing ffmpeg, it would be good to create tests that isolate these libraries.

@cjdcordeiro cjdcordeiro requested a review from a team September 30, 2024 12:34
@cjdcordeiro cjdcordeiro self-assigned this Sep 30, 2024
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks!

@cjdcordeiro cjdcordeiro merged commit 5acb6fb into canonical:ubuntu-24.04 Oct 1, 2024
14 checks passed
@HadrienPatte HadrienPatte deleted the ffmpeg-deps-4 branch October 1, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants