-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): openjdk-17 headless slices #350
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: slices/openjdk-17-jre-headless.yaml@@ -1,11 +1,6 @@
-ca-certificates-java
-java-common
libc6
libgcc-s1
-libjpeg8
-liblcms2-2
libnss3
libpcsclite1
libstdc++6
-util-linux
zlib1g |
Add openjdk-17 slices except AWT slice as it needs harfbuzz to be merged.
23d5abc
to
9f3102d
Compare
keytool requires security slice to be installed to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Just a few questions and suggestions below.
Classes cache https://openjdk.org/jeps/310 is used to improve startup and footprint of the JVM.
… into 24.04-openjdk-17
Include management, debug and jfr into the standard slice.
Needs pipeline retry - spread failing with "cannot fetch from archive" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
I have re-triggered the failing pipeline. It's passing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests for individual binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyvm ;) lgtm. waiting 2nd approval
See canonical#363. Remove a sample packaging artifact.
Note: dropped jvm.cfg-default #363 |
Proposed changes
Add openjdk-17 slices except AWT slice as it needs harfbuzz to be merged.
Related issues/PRs
harfbuzz
Forward porting
Checklist
Additional Context