Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): openjdk-17 headless slices #350

Open
wants to merge 25 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

vpa1977
Copy link

@vpa1977 vpa1977 commented Sep 18, 2024

Proposed changes

Add openjdk-17 slices except AWT slice as it needs harfbuzz to be merged.

Related issues/PRs

harfbuzz

Forward porting

Checklist

Additional Context

Copy link

github-actions bot commented Sep 18, 2024

Diff of dependencies:

slices/openjdk-17-jre-headless.yaml
@@ -1,11 +1,6 @@
-ca-certificates-java
-java-common
 libc6
 libgcc-s1
-libjpeg8
-liblcms2-2
 libnss3
 libpcsclite1
 libstdc++6
-util-linux
 zlib1g

@vpa1977 vpa1977 changed the title feat: openjdk-17 slices feat(24.04): openjdk-17 headless slices Sep 18, 2024
Add openjdk-17 slices except AWT slice as it needs harfbuzz to be merged.
keytool requires security slice to be installed to work.
@vpa1977 vpa1977 marked this pull request as ready for review September 18, 2024 05:26
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Just a few questions and suggestions below.

tests/spread/integration/openjdk-17-jre-headless/task.yaml Outdated Show resolved Hide resolved
slices/openjdk-17-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-17-jre-headless.yaml Show resolved Hide resolved
slices/openjdk-17-jre-headless.yaml Show resolved Hide resolved
@vpa1977
Copy link
Author

vpa1977 commented Sep 24, 2024

Needs pipeline retry - spread failing with "cannot fetch from archive"

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

I have re-triggered the failing pipeline. It's passing now.

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again the same comments as in #313 and #349

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm ;) lgtm. waiting 2nd approval

@vpa1977
Copy link
Author

vpa1977 commented Oct 8, 2024

Note: dropped jvm.cfg-default #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants