Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spread): check chisel binary integrity #365

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

Proposed changes

Chisel's v1.0.0 has 2 release assets per architecture now. This PR fixes the installation of Chisel in the spread system and add integrity verification of the downloaded binary.

Checklist

Additional Context

Quick test via: spread lxd:tests/spread/integration/base-passwd

@cjdcordeiro cjdcordeiro requested a review from a team October 10, 2024 08:11
Copy link

Diff of dependencies:
None found.


Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cjdcordeiro
Copy link
Collaborator Author

Simple CI fix - merging

@cjdcordeiro cjdcordeiro merged commit f9129e6 into canonical:ubuntu-24.04 Oct 10, 2024
14 checks passed
@cjdcordeiro cjdcordeiro deleted the sha384-24.04 branch October 10, 2024 08:35
rebornplusplus added a commit to rebornplusplus/chisel-releases that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants