[22.04] Add slices for libgnutls, libsoup and glib-networking #49
Conversation
ozanmakes
changed the title
There was a problem hiding this comment.
Thanks for the contribution @osener . This is a very welcome addition :)
Although functional, I've left a few requests that relate to the design of slices. The overall message is that we should be as conservative as possible when it comes to the use of globs. With these changes, it should be ready to be merged.
slices/publicsuffix.yaml
Outdated
| slices: | ||
| data: | ||
| contents: | ||
| /usr/share/publicsuffix/*: |
There was a problem hiding this comment.
this path seems to be specific to this pkg, so the glob is a bit safer to use here. Nonetheless, given that there are only 3 files within, it is safer to just list them explicitly :)
|
Hi @ozanmakes, it has been some time since the last activity here. The PR could use a rebase/merge since there are some conflicts already. There are some changes requested as well. Will you please let me know if you have some time to go over the comments and update the PR? Thank you! |
|
Diff of dependencies: slices/glib-networking-services.yaml@@ -1,4 +0,0 @@
-glib-networking-common
-libc6
-libglib2.0-0
-libproxy1v5slices/gsettings-desktop-schemas.yaml@@ -1,3 +0,0 @@
-dconf-gsettings-backend
-gsettings-backend
-session-migration |
This PR adds various networking libraries and their dependencies.