Implement Refresh Worker Certificates Logic #65
+194
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks a lot @mateoflorido! Wonderful job! Almost LGTM, just left some minor comments and questions.
berkayoz
reviewed
Oct 8, 2024
mateoflorido
force-pushed
the
KU-1602/refresh-worker-certs
branch
from
6adb9af
to
78f1b48
Compare
HomayoonAlimohammadi
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Amazing job! Thanks a lot @mateoflorido! LGTM, Just some very minor comments.
|
|
||
| var seconds int | ||
|
|
||
| eg, ctx := errgroup.WithContext(ctx) |
There was a problem hiding this comment.
Really liked this use of errgroup! Amazing!
berkayoz
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM, seems like @HomayoonAlimohammadi covered most of the comments.
mateoflorido
force-pushed
the
KU-1602/refresh-worker-certs
branch
from
2f8511d
to
5887593
Compare
|
LGTM @mateoflorido but as also discussed yesterday with @HomayoonAlimohammadi I'd like to have a test for this before we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request is dependent on
k8s-snap#713Overview
This update implements the logic to handle certificate refresh for worker nodes.
Changes