Fix alerts assignment when event is None #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
requested review from
Abuelodelanada,
PietroPasotti,
dstathis,
simskij and
lucabello
as code owners
przemeklal
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The nrpe targets changed event hook is sometimes called without an event arg. In such cases we cannot obtain alerts from
eventattributes.Solution
Obtain alerts from stored state. This is the same as #94, but follows-up #100.
Fixes #102.
Context
Testing Instructions
See newly added utest. Before this change, the utest would fail with the same error reported in #102.
Release Notes