chore: merge the latest starbase #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action looks specifically for ".yml", and not ".yaml".
Co-authored-by: Tiago Nobrega <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This allows starbase to have its own tests and allow for cleaner merges of starbase into other repositories. Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Callahan Kovacs <[email protected]>
`module = ["starcraft"]` only checks checks the `starcraft` main package, and not any sub-packages and modules.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Files like README.md and HACKING.md are linted by sphinx-lint. Signed-off-by: Callahan Kovacs <[email protected]>
The directive is finnicky with regards to globbing, so the tests and docs were being included in the final wheel package.
The idea is this: since we have a few tests that are worth running in "downstream" projects (those that merge starbase periodically), instead of having to adapt every test individually in every downstream project we'll use a fixture (project_main_module) that provides the imported module object. So in starbase is returns the 'starcraft' module. The tests are then updated to use this fixture instead of importing the module directly. Downstream projects therefore only need to update the fixture's implementation and the tests will (well, should) work.
Co-authored-by: Tiago Nobrega <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…#117) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Callahan Kovacs <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
lengau
force-pushed
the
starbase
branch
3 times, most recently
from
9860629
to
44876cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?