Cleanup repo #1394
Merged
Cleanup repo #1394
+7
−904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some old docs that aren't too useful or were outdated, like asyncapi, facade and howto vault. Additionally I've renamed compose-common, so it's in the conventional naming format for multiple files. We had an old docker file that wasn't used, that's been cleaned up too and finally there was a set-version script that wasn't used. I removed this directory too.
kian99
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Should we rather update this doc to document the JIMM facades? Maybe just one-liners like
JIMM offers these custom facades:
- AddRelation
- ...
There was a problem hiding this comment.
Honestly I don't see a point... Proper doccos in jaas-docs is better I think idk... we can revisit doccing jaas specific later maybe?
There was a problem hiding this comment.
Actually lets see what guys think @alesstimec @SimoneDutto
There was a problem hiding this comment.
since we have the godoc in JIMM methods i dont' see the point of having this doc
SimoneDutto
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
since we have the godoc in JIMM methods i dont' see the point of having this doc
|
OKi, will merge @SimoneDutto @kian99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some old docs that aren't too useful or were outdated, like asyncapi, facade and howto vault. Additionally I've renamed compose-common, so it's in the conventional naming format for multiple files. We had an old docker file that wasn't used, that's been cleaned up too and finally there was a set-version script that wasn't used. I removed this directory too.
Description
The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers