Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dashboard #1398

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Conversation

ale8k
Copy link
Contributor

@ale8k ale8k commented Oct 18, 2024

We don't serve the dashboard anymore and we're simply just redirecting to it on /dashboard, but I don't think there is a need? Why would we need to know the dashboard URL? Removing this removes a configuration value.

Correct me if I'm wrong and I'll close this PR.

Description

The what and why - include a summary of the change, describe what it does, and include relevant motivation and context.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

We don't serve the dashboard anymore and we're simply just redirecting to it on /dashboard, but I don't think there is a need?
@ale8k ale8k requested a review from a team as a code owner October 18, 2024 09:26
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need the dashboard location to redirect there after a browser login

@ale8k
Copy link
Contributor Author

ale8k commented Oct 18, 2024

I believe we need the dashboard location to redirect there after a browser login

That's FinalRedirectURL or w/e it's called @kian99

Copy link
Contributor

@SimoneDutto SimoneDutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants