Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up rocks and test #33

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Cleans up rocks and test #33

merged 2 commits into from
Sep 17, 2024

Conversation

claudiubelu
Copy link
Contributor

Corrects URLs which are pointing towards incorrect things.

Adds additional links to some of the rockcraft.yaml files, bringing them more in line with the other ones.

Removes unnecessry cd $CRAFT_PART_SRC.

Cleans up integration test. Removes unused dictionary. Refactors the code.

Corrects URLs which are pointing towards incorrect things.

Adds additional links to some of the rockcraft.yaml files, bringing them
more in line with the other ones.

Removes unnecessry cd $CRAFT_PART_SRC
Removes unused dictionary.

Refactors the code.
@claudiubelu claudiubelu requested a review from a team as a code owner September 17, 2024 06:56
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 943fbc1 into canonical:main Sep 17, 2024
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants