Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kratos rock release #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nsklikas
Copy link

Add files for the Kratos ROCK

Didn't add any documentation or contacts, hope that's ok.

@cjdcordeiro
Copy link
Collaborator

Thanks for this contribution. This seems to be a new ROCK and you're asking for it to be released into DH and ECR, so before even starting the review, I suggest you go through the Contributor's Contract (find the link from last week's workshop) and reach out to @valentincanonical about whether this should be under the "ubuntu" namespace or not

Copy link

@valentincanonical valentincanonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this image might eventually make it to the Ubuntu namespace as part of Canonical's images portfolio but this will happen later when there's better testing, documentation, and the team is ready to commit to supporting these images.

For now, I suggest removing the release-to / releases options, so that the OCI factory will still build these Rocks but not publish them anywhere beyond the staging GHCR area.

oci/kratos/builds.yaml Outdated Show resolved Hide resolved
Co-authored-by: Valentin Viennot <[email protected]>
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking the time to comment, but we wanted to merge some disruptive changes before approving this first PR :)

Could you please update the builds.yaml, renaming it to images.yaml and replacing the images keyword by upload (according to the new schema)

@cjdcordeiro
Copy link
Collaborator

Hi again! I'm just reviving this thread to know we it should be resumed or closed ;)

(FYI @nsklikas )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants