Add 'deprecated' field for depreacted section generation in image docs #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
force-pushed
the
ROCKS-1224/support-deprecated-channels-tags
branch
from
e1cc71f
to
d74e760
Compare
2 tasks
SamirPS
reviewed
Jul 17, 2024
| @@ -269,6 +271,11 @@ def build_releases_data( | |||
| "until": eol.strftime("%m/%Y") | |||
| } | |||
|
|
|||
| if eol > datetime.now(timezone.utc): | |||
There was a problem hiding this comment.
why don't use datetime.UTC? https://docs.python.org/3/library/datetime.html#datetime.UTC
cjdcordeiro
reviewed
Oct 9, 2024
Comment on lines
+76
to
+78
| v["end-of-life"] for v in builds[img_number]["release"].values() | ||
| ), "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=timezone.utc) | ||
| if min_eol < datetime.now(timezone.utc): |
There was a problem hiding this comment.
FYI these dates are ISO formatted, so you should be able to compare them as strings
| v["end-of-life"] for v in builds[img_number]["release"].values() | ||
| ), "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=timezone.utc) | ||
| if min_eol < datetime.now(timezone.utc): | ||
| print("Track skipped because it reached its end of life") |
There was a problem hiding this comment.
Isn't this too late? I.e. the name and path are set before this, which means that even if there's no release, the image will still be built and tested right? But do we want that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
The documentation generator for rocks is missing some parts necessary to generate the
Deprecated channels & tagssection.This PR provides the necessary values so that the generator can identify the deperacted tags and list them accordingly, using the expired end-of-life value of each track to determine whether it is depreacted or not.
Related issues
OCI-Factory builds won't work if one image's track has an expired EOL value. Another PR to fix that issue will be out soon.