-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5587] Fix private IP resolution to use juju spaces #122
Conversation
The result of this PR:
Running the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks pedro, I have some questions.
Co-authored-by: Mehdi Bendriss <[email protected]>
Co-authored-by: Mehdi Bendriss <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some minor questions.
1597e0a
to
7af06f5
Compare
7af06f5
to
8910a3d
Compare
Up to this point OSD was taking the local IP (using the Python
socket
library) for the application endpoint.However we need to use the IP published by Juju instead (
Model.get_binding()
) -- as this is the one that can be contacted externally.The change has a impact on TLS certificates as well (as we are adjusting the IPs appearing in the certificate request accordingly).
Closes #121