publish_host is a single IP, not a list
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneradoi
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Hey @phvalguima Just for my understanding: Why a separate PR if it's already included in #367?
Edit: Ok nvm, just saw your message in the chat.
Mehdi-Bendriss
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
publish_hostis being dealt, it is expected a list of hostnames / IPs. However, publish_host has a single value. Hence, we should not filter it withset().This fix has been originally applied in this PR: #367. It has been also verified with successful passed runs of
test_ha_networking.pychecks, which triggers this logic.