Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5599][Juju 3.6] Break PR/worflow & nightly tests + DPW update #467

Merged
merged 29 commits into from
Oct 7, 2024

Conversation

phvalguima
Copy link
Contributor

@phvalguima phvalguima commented Oct 2, 2024

Updates the data platform workflow to the latest version: 22.0.0.

Breaks down the integration tests between 3.6/beta for nightly run + 3.5 for PR / merges to 2/edge branch.

@phvalguima phvalguima requested a review from delgod October 2, 2024 20:23
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

PR description appears to be outdated

Breaks the ci.yaml file into workflow.yaml, for PRs and workflows; and nightly.yaml for the CI runs at night.

I would not recommend that approach—the approach currently in the PR is recommended instead

@phvalguima
Copy link
Contributor Author

We should stay with pinned juju agent + a renovate config to bump this version, as described here: #470

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to remove build wrapper from tox.ini

full migration instructions: https://github.com/canonical/data-platform-workflows/releases/tag/v22.0.0

charmcraft.yaml Show resolved Hide resolved
@carlcsaposs-canonical
Copy link
Contributor

also please update dpw in pyproject.toml—compatibility only guaranteed if every dpw is on the same version

(fyi, the renovate preset can take care of this for you)

poetry.lock Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Oct 5, 2024
Copy link
Contributor

@juditnovak juditnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phvalguima phvalguima merged commit bec01ba into 2/edge Oct 7, 2024
7 of 8 checks passed
@phvalguima phvalguima deleted the DPE-5599-break-ci.yaml branch October 7, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants