Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable Python 3.13 in CI #1412

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Oct 8, 2024

Python 3.13 has been released yesterday.
Let's enable it in our CI.

@@ -43,7 +43,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
python-version: ["3.8", "3.10", "3.12"]
python-version: ["3.8", "3.10", "3.12", "3.13"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to having a new discussion if you want, but on the last PR that updated this we decided to run the tests just on the LTS versions (3.8, 3.10, 3.12), but do the pip install on 3.13 (which it already is, but we could remove the pre-release).

I think we should keep "test" and "test-real-pebble" on just 3.8/3.10/3.12, but update "lint" to 3.13 (it's currently still on 3.11).

That said, it might be a few days premature -- looks like the GitHub Action can't find Python 3.13 yet, hence the failed runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did, didn't we?

I think that lint is a moot point, as it comprises ruff (rust) and codespell (python, no deps) tools.

Let's chat when the actions catch up with the release.

@dimaqq dimaqq marked this pull request as draft October 8, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants