-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenID Connect integration #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 46 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
12 | 1 | 33 | 0 |
Click to see the invalid file list
- tests/integration/prepare.sh
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few questions, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 7eb2df9
Static code analysis report
|
Add OpenID Connect integration to the Penpot charm using the
oauth
charm library.Since SMTP is required when OpenID is enabled in Penpot, SMTP integration is now a requirement when enabling OAuth.
Integration tests for oauth have been added using
oauth_tools
from theidentity-bundle
. However, as there are some issues currently with theoauth_tools
, please withhold merging this pull request until the problems have been fixed upstream.