feat: add desktop icon for prompting-client-ui app #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
force-pushed
the
desktop-icon
branch
from
bfc572b
to
c38a1c4
Compare
d-loose
force-pushed
the
desktop-icon
branch
from
c38a1c4
to
4f8aba1
Compare
d-loose
changed the title
I followed what @sminez did for the security center - was there a reason you added a png there? I'd be happy to just use the svg. |
|
No, there wasn't... It should work fine with a svg only... |
|
Merging this as-is, to be consistent with the other desktop apps, that also use png icons at the moment. We can test the svg in case we observe any scaling issues with the png. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate it if someone could double-check that the icon now displays correctly - there's a snap build here.
UDENG-4335