feat: Scripted client nullable replies #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee a prompt but not respond to it
… in the scripted client
sminez
commented
Sep 27, 2024
| @@ -95,14 +99,25 @@ impl TypedPromptFilter { | |||
| } | |||
| } | |||
|
|
|||
| /// Override the default handling for a missing key in being parsed as `None` so that only an | |||
| /// explicit value of `null` is accepted. | |||
| fn explicit_null<'de, T, D>(de: D) -> Result<Option<T>, D::Error> | |||
There was a problem hiding this comment.
This is what allows us to distinguish the field being explicitly specified as null vs simply being omitted. (The default behaviour of serde when deserializing into an Option<T> field is to treat both the same).
This is adapted form the example shown here in order to emit an error in the case of a missing field rather than parsing into an Option<Option<T>> and having to handle the validation explicitly after the struct has been deserialized.
olivercalder
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support not replying to every prompt in a scripted client prompt-sequence.
Currently, prompting-client.scripted accepts scripts which have a top-level "prompt-filter" and a "prompts" list, which is a list of json objects with two mandatory fields: "prompt-filter" and "reply". The scripted client expects relevant prompts to match the filters specified in the "prompts" list in order, and for each one, immediately sends back the accompanying reply.
However, to write a spread test which mimics the
create_multiple_actioned_by_other_pidintegration test, we need to be able to attempt multiple writes (and check that those attempts occurred as expected), and then on a subsequent attempt, reply with a rule which then actions the previous prompts as well.The docs update and new test data cover the new supported syntax for a prompt-sequence.
Tracked internally by https://warthogs.atlassian.net/browse/UDENG-4782