Adds tox.ini and basic rock sanity tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
adds-tests
branch
2 times, most recently
from
2ea19c0
to
3992179
Compare
claudiubelu
changed the title
bschimke95
approved these changes
Jul 18, 2024
Adds the following tox targets: format, lint, sanity, integration. Adds basic rock tests, checking that the expected files exist in the rock, and checking the added executables outputs. Note that Pebble was recently updated, no longer allowing exec after --verbose (which is in the entrypoint). Using the --entrypoint docker run parameter instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following tox targets: format, lint, sanity, integration.
Adds basic rock tests, checking that the expected files exist in the rock, and checking the added executables outputs.
Note that Pebble was recently updated, no longer allowing exec after
--verbose(which is in the entrypoint). Using the--entrypointdocker run parameter instead.Depends-On: canonical/k8s-test-harness#11