Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds other versions of Whereabouts #9

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jul 16, 2024

Added support for Velero 1.12.1 and 1.9.5. Added rockcraft.yaml files based on their Dockerfiles.

Depends-On: canonical/k8s-test-harness#11
Depends-On: #11

@claudiubelu claudiubelu requested a review from a team as a code owner July 16, 2024 14:09
@claudiubelu claudiubelu changed the title Other versions Adds other versions of Whereabouts Jul 16, 2024
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict

@claudiubelu
Copy link
Contributor Author

Please resolve conflict

Done

Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

tests/sanity/test_whereabouts.py Outdated Show resolved Hide resolved
Added support for versions 0.5.4 and 0.6.1. Added rockcraft.yaml
files based on their Dockerfiles.

Adds /host folder in the rocks. The /install-cni.sh script requires
this folder. It does mkdir it, but the bitnami helm chart creates
the daemonsets with read-only filesystem, making it impossible to
create the folder.
@bschimke95
Copy link
Collaborator

Only image upload to ghcr fails because of external contributor - merging.

@bschimke95 bschimke95 merged commit f73a54f into canonical:main Jul 19, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants