Event Broker: S/4HANA Cloud to CAP #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjvans
commented
Jul 29, 2024
•
sjvans
commented
sjvans
commented
Aug 7, 2024
| * filling in missing events as found on SAP Business Accelerator Hub | ||
| */ | ||
| using { API_BUSINESS_PARTNER as S4 } from './external/API_BUSINESS_PARTNER'; | ||
| extend service S4 with { |
There was a problem hiding this comment.
with ORD, we should create a new service instead of extending the imported one
sjvans
commented
Aug 7, 2024
| @@ -28,7 +28,32 @@ class ProcessorService extends cds.ApplicationService { | |||
| } | |||
| } | |||
|
|
|||
| module.exports = { ProcessorService } | |||
| class AdminService extends cds.ApplicationService { | |||
There was a problem hiding this comment.
as we're not serving service S4, we can't implement it either (i.e., class S4 extends ...)
→ implement in AdminService instead, which is somewhat a hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.