Add key command #66
Open
Add key command #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generates a AWS KMS key with a policy that has the PCRs required by the KMS to perform attestation against decrypt requests. Example coming soon.
jvmncs
reviewed
Dec 2, 2022
| use tracing::instrument; | ||
| use uuid::Uuid; | ||
|
|
||
| pub const KEY_POLICY_TEMPLATE: &str = r##"{ |
There was a problem hiding this comment.
any reason why we're not treating this the same way as the CF Template? seems like we already have all the structure to set things up that way, not sure why we'd do differently
There was a problem hiding this comment.
That's a cloudformation specific thing as far as I can tell.
Comment on lines
+127
to
+132
| // "Measurements": { | ||
| // "HashAlgorithm": "Sha384 { ... }", | ||
| // "PCR0": "6e5f9f840dd17f3ab4deaf1954e65302642ac4ee4365382afa5ec970045d2a3448f222431208494daa1fa59d78b8b3f8", | ||
| // "PCR1": "bcdf05fefccaa8e55bf2c8d6dee9e79bbff31e34bf28a99aa19e6b29c37ee80b214a414b7607236edf26fcb78654e63f", | ||
| // "PCR2": "d8afbe78d624566500651d1abd46c87c0b32c6ae309690dcaa26d87f8069a4828a9a95b4ea5c05f765ae8571728becaa" | ||
| // }, |
There was a problem hiding this comment.
is this here for a reason or just leftover?
There was a problem hiding this comment.
Yeah just forgot to delete.
gavinuhma
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates a AWS KMS key with a policy that has the PCRs required by the KMS to perform attestation against decrypt requests.
Example coming soon.