-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add decorator in dataTable #18114
Open
preetibansalui
wants to merge
21
commits into
carbon-design-system:main
Choose a base branch
from
preetibansalui:18005-add-decorator-in-dataTable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7a4f19d
chore: add decorator in dataTable
preetibansalui e5ed412
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui 7dd3da9
fix: replace slug with ai-lable
preetibansalui 05f0a99
fix: test cases
preetibansalui e2515e0
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui fbe8f25
fix: test case
preetibansalui aa7e98d
fix: test cases
preetibansalui 9db81fc
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui 473e0ee
fix: changed const name as per PR suggestions
preetibansalui 6b6179c
Merge branch 'main' into 18005-add-decorator-in-dataTable
tay1orjones 9134a4b
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui fd9b843
fix: css issues
preetibansalui 703ab52
fix: css
preetibansalui 4fa7717
fix: test
preetibansalui 3ae6ca9
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui d4b9d88
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui 3a37225
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui a646c18
fix: removed decorator stories
preetibansalui ea1c8c7
fix: test
preetibansalui adb1186
Merge branch 'main' into 18005-add-decorator-in-dataTable
preetibansalui ff2e40c
fix: test
preetibansalui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
packages/react/src/components/DataTable/TableDecoratorRow.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/** | ||
* Copyright IBM Corp. 2016, 2023 | ||
* | ||
* This source code is licensed under the Apache-2.0 license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
import PropTypes from 'prop-types'; | ||
import React, { ReactNode } from 'react'; | ||
import classNames from 'classnames'; | ||
import { usePrefix } from '../../internal/usePrefix'; | ||
import deprecate from '../../prop-types/deprecate'; | ||
|
||
export interface TableDecoratorRowProps { | ||
/** | ||
* The CSS class names of the cell that wraps the underlying input control | ||
*/ | ||
className?: string; | ||
|
||
/** | ||
* **Experimental**: Provide a `decorator` component to be rendered inside the `TableDecoratorRow` component | ||
*/ | ||
decorator?: ReactNode; | ||
} | ||
|
||
const TableDecoratorRow = ({ | ||
className, | ||
decorator, | ||
}: TableDecoratorRowProps) => { | ||
const prefix = usePrefix(); | ||
const TableDecoratorRowClasses = classNames({ | ||
...(className && { [className]: true }), | ||
[`${prefix}--table-column-decorator`]: true, | ||
[`${prefix}--table-column-decorator--active`]: decorator, | ||
}); | ||
|
||
let normalizedDecorator = React.isValidElement(decorator) ? decorator : null; | ||
if ( | ||
normalizedDecorator && | ||
normalizedDecorator['type']?.displayName === 'AILabel' | ||
) { | ||
normalizedDecorator = React.cloneElement( | ||
normalizedDecorator as React.ReactElement<any>, | ||
{ | ||
size: 'mini', | ||
} | ||
); | ||
} | ||
|
||
return <td className={TableDecoratorRowClasses}>{normalizedDecorator}</td>; | ||
}; | ||
|
||
TableDecoratorRow.displayName = 'TableDecoratorRow'; | ||
TableDecoratorRow.propTypes = { | ||
/** | ||
* The CSS class names of the cell that wraps the underlying input control | ||
*/ | ||
className: PropTypes.string, | ||
|
||
/** | ||
* **Experimental**: Provide a `decorator` component to be rendered inside the `TableDecoratorRow` component | ||
*/ | ||
decorator: PropTypes.node, | ||
}; | ||
|
||
export default TableDecoratorRow; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need both untill v12... people could be targetting these classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ari, here Slug is just a constant name which I have changed to decorator in line no 78 of this file and added condition for both Slug or decorator. However, yes we can add both the classes [
${prefix}--data-table--slug-row
] and [${prefix}--data-table--ai-label-row
] on same condition keeping in mind if any user is using the [${prefix}--data-table--slug-row
] class name.