Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tag token colors #18265

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Dec 19, 2024

Closes #18264

The cds--definition-term class was styling the label color. Now, we ensure the correct style is applied to the label by targeting it directly.

Changelog

Testing / Reviewing

  • It should not change any color.
  • It was tested in the code as well. But here it is an Stacklbitz example

@guidari guidari requested a review from a team as a code owner December 19, 2024 18:16
@guidari guidari changed the title Fixed tag colors Fixed tag token colors Dec 19, 2024
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 49804df
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67648545c1e72400084eb572
😎 Deploy Preview https://deploy-preview-18265--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 49804df
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67648545710fa60008442006
😎 Deploy Preview https://deploy-preview-18265--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 49804df
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67648546cae31b0009793e82
😎 Deploy Preview https://deploy-preview-18265--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (d56c885) to head (49804df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18265   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         404      404           
  Lines       14359    14359           
  Branches     4606     4606           
=======================================
  Hits        12107    12107           
  Misses       2090     2090           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@ariellalgilmore ariellalgilmore added this pull request to the merge queue Dec 23, 2024
Merged via the queue into carbon-design-system:main with commit 03170a8 Dec 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: <Tag> carbon component hiding the content passed to it
4 participants