Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: filter requested endpoints by interface #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NotRealKomar
Copy link

@NotRealKomar NotRealKomar commented Oct 18, 2024

Sometimes on connection, Swift server returns endpoints in the wrong order, so the client may use the admin endpoint instead of the public one, for instance.

     // Will take the first endpoint with no other checks
      _config.endpoints = _serviceCatalog.endpoints.find((element) => {
        return element.region?.toLowerCase() === _storage.region?.toLowerCase();
      });

That leads to forbidden errors in some cases.

The suggestion is to add an option to filter endpoints by their interface

@NotRealKomar NotRealKomar changed the title Swift: filter requested endpoints by an interface Swift: filter requested endpoints by interface Oct 18, 2024
@dgrelaud
Copy link
Member

Thank you for the PR 🙏

We will review it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants