Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeouts for fetching node in benchmarks and e2e tests #3081

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Jan 13, 2022

  • I have increased timeouts in restoration benchmarks and e2e tests

Comments

Follow up to #3079.

  • e2e tests 120 mins was not enough for MacOS.
  • hopefully the same issue in benchmarks.
    • 🧪 Testing 180mins ❌
    • 🧪 Testing 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node)

Issue Number

@piotr-iohk piotr-iohk self-assigned this Jan 13, 2022
@piotr-iohk piotr-iohk force-pushed the piotr/node-related-timeouts-follow-up branch from 0e8c829 to 29a9b30 Compare January 13, 2022 15:05
@piotr-iohk piotr-iohk requested a review from rvl January 14, 2022 08:13
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 14, 2022
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=piotr-iohk a=piotr-iohk

- [x] I have increased timeouts in restoration benchmarks and e2e tests

### Comments

Follow up to #3079.
 - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). 
   - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ 
 - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218)  180mins ❌ 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node)

### Issue Number

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 14, 2022

Build failed:

https://hydra.iohk.io/build/11788738/nixlog/1

Failures:

  src/Test/Integration/Scenario/API/Shelley/Addresses.hs:105:5:
  1) API Specifications, SHELLEY_ADDRESSES, BYRON_ADDRESS_LIST - Byron wallet on Shelley ep
       uncaught exception: ProcessHasExited
       ProcessHasExited "cluster didn't start correctly: [Left user error (Waited too long for: pool registration)]" (ExitFailure 1)

  To rerun use: --match "/API Specifications/SHELLEY_ADDRESSES/BYRON_ADDRESS_LIST - Byron wallet on Shelley ep/"

#3123

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 14, 2022
3081: Increase timeouts for fetching node in benchmarks and e2e tests r=piotr-iohk a=piotr-iohk

- [x] I have increased timeouts in restoration benchmarks and e2e tests

### Comments

Follow up to #3079.
 - e2e tests 120 mins was not enough for [MacOS](https://github.com/input-output-hk/cardano-wallet/actions/runs/1689464914). 
   - 🧪 [Testing](https://github.com/input-output-hk/cardano-wallet/actions/runs/1691714591). 180mins ✔️ 
 - hopefully the same issue in [benchmarks](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1216#68ecaf3e-2649-4d9e-804e-bef3bad97fc). 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1218)  180mins ❌ 
   - 🧪 [Testing](https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1219) 240mins ✔️ (build failed due to cancellation signal 🤔 , but passed through connecting to the node)

### Issue Number

<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
  Note: Jira issues of the form ADP- will be auto-linked. -->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 14, 2022

Build failed:

https://hydra.iohk.io/build/11784686/nixlog/1

Failures:

  src/Test/Integration/Scenario/API/Shelley/Addresses.hs:105:5:
  1) API Specifications, SHELLEY_ADDRESSES, BYRON_ADDRESS_LIST - Byron wallet on Shelley ep
       uncaught exception: ProcessHasExited
       ProcessHasExited "cluster didn't start correctly: [Left user error (Waited too long for: pool registration)]" (ExitFailure 1)

  To rerun use: --match "/API Specifications/SHELLEY_ADDRESSES/BYRON_ADDRESS_LIST - Byron wallet on Shelley ep/"

#3123

@rvl
Copy link
Contributor

rvl commented Jan 18, 2022

Hmm... same integration tests setup error twice in a row on macos - and they weren't cached failures.

bors r+

@piotr-iohk
Copy link
Contributor Author

Hmm... same integration tests setup error twice in a row on macos - and they weren't cached failures.

Yes, failure is related to token metadata server (https://input-output-rnd.slack.com/archives/G3TLHGM18/p1642439837011700).

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 18, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit a5085ac into master Jan 18, 2022
@iohk-bors iohk-bors bot deleted the piotr/node-related-timeouts-follow-up branch January 18, 2022 09:26
@piotr-iohk
Copy link
Contributor Author

Hmm... same integration tests setup error twice in a row on macos - and they weren't cached failures.

Yes, failure is related to token metadata server (https://input-output-rnd.slack.com/archives/G3TLHGM18/p1642439837011700).

Oh, sorry you meant integration tests setup... misread. Pls ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants