Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remade most pages + UI fixes + Photobox integration + more #60

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

weebthedev
Copy link

No description provided.

Copy link
Member

@sosweetham sosweetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly, hardcode needs to be removed, theme config can be more concise, theme needs to be set using cookie

@@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width" />
%sveltekit.head%
</head>
<body data-sveltekit-preload-data="hover" class="h-full overflow-hidden" data-theme="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set this using cookie like before

@@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width" />
%sveltekit.head%
</head>
<body data-sveltekit-preload-data="hover" class="h-full overflow-hidden" data-theme="">
<body data-sveltekit-preload-data="hover" class="h-full overflow-hidden" data-theme="my-custom-theme">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont hardcode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see hooks.server.ts and change that from modern to this, also change it's name from my-custom-theme to weeb-crimson or smthn like that

src/routes/(protected)/a/[vanity]/+page.svelte Outdated Show resolved Hide resolved
src/routes/(protected)/a/[vanity]/+page.svelte Outdated Show resolved Hide resolved
src/routes/(protected)/settings/+page.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
src/routes/+page.svelte Outdated Show resolved Hide resolved
Comment on lines -21 to -56
preset: [
{
name: 'modern',
enhancements: true
},
{
name: 'wintry',
enhancements: true
},
{
name: 'hamlindigo',
enhancements: true
},
{
name: 'rocket',
enhancements: true
},
{
name: 'sahara',
enhancements: true
},
{
name: 'gold-nouveau',
enhancements: true
},
{
name: 'vintage',
enhancements: true
},
{
name: 'seafoam',
enhancements: true
},
{
name: 'crimson',
enhancements: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add as comment

Comment on lines -49 to -63
const themes = [
{ type: 'skeleton', name: 'Skeleton', icon: '💀' },
{ type: 'wintry', name: 'Wintry', icon: '🌨️' },
{ type: 'modern', name: 'Modern', icon: '🤖' },
{ type: 'rocket', name: 'Rocket', icon: '🚀' },
{ type: 'seafoam', name: 'Seafoam', icon: '🧜‍♀️' },
{ type: 'vintage', name: 'Vintage', icon: '📺' },
{ type: 'sahara', name: 'Sahara', icon: '🏜️' },
{ type: 'hamlindigo', name: 'Hamlindigo', icon: '👔' },
{ type: 'gold-nouveau', name: 'Gold Nouveau', icon: '💫' },
{ type: 'crimson', name: 'Crimson', icon: '⭕' }
// { type: 'seasonal', name: 'Seasonal', icon: '🎆' }
// { type: 'test', name: 'Test', icon: '🚧' },
];
let sidebar: string = 'sidebar';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back as comment

// =~= Theme Properties =~=
'--theme-font-family-base':
"Inter, ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial,\n\t\t'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'",
'--theme-font-family-heading': 'Inter, system-ui',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import the custom theme and change, just this

@sosweetham
Copy link
Member

image bring this menu back, its required for navigation on mobile, also fix it's button click while you are on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants