Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets #188 & 204 #201

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Tickets #188 & 204 #201

wants to merge 15 commits into from

Conversation

skarabocu
Copy link

No description provided.

@skarabocu skarabocu changed the title Ticket #188 Tickets #188 & 204 Jun 17, 2019
@skarabocu
Copy link
Author

TODO List for Asset-Isolated View:

  • I put and fixed the asset-embedded view on top of the chart and placed the information on the card correctly. However, I could not find a way to shrink the asset-embedded view as a user scroll down.
    -I could not find the way to change the structure of the high-chart, so the range-selector is still located on top of the chart.
    -The chart that we are using is a StockChart, not an AreaChart. Thus, I was not able to paint the area under the chart as specified in the new designs. However, I created a variable for the desired color, called '--portfolio-chart-area' in the high-chart.css file.
    -The dropdown menu is dependent to a button, since I could not find a way to handle the event just through the dropdown menu.

skarabocu and others added 15 commits June 28, 2019 11:10
@skarabocu @burieberry
Redesigned the ethereum card according to the recent designs.
79d0a08
@skarabocu @burieberry
Update asset-embedded.css
665a12b 
Aligned the address and the title.
@skarabocu @burieberry
Started to the redesign of isolated view.
b059e12
@skarabocu @burieberry
Added the icon.
3681acd
@skarabocu @burieberry
Added a dropdown menu for changing the currency.
405491d
@skarabocu @burieberry
Added the scrolling down features and white background for the isolat…
3c7a47e 
…ed view, and fixed the justify-content issue for the embedded card address.
@skarabocu @burieberry
Changed the CSS of the highchart to adapt the new design.
d3048f5
@skarabocu @burieberry
Modified the dropdown, so the currency can be changed without a switc…
0539d32 
…h button.
@skarabocu @burieberry
A small change for dropdown.
030da11
@bagby @burieberry
revert yarn.lock
743585e
@skarabocu @burieberry
Solved the bug with yarn.lock
89dbe12
@skarabocu @burieberry
Get rid of a useless console.log
d66d504
@skarabocu @burieberry
Solved linting errors for currencies and selectedSymbol.
bf36023
@skarabocu @burieberry
Small fix for linting error.
a96e94e
@burieberry
Fix tests
fb80b26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skarabocu @bagby @burieberry