Fix missing arg #604
Merged
Fix missing arg #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carkod
force-pushed
the
fix-missing-arg
branch
3 times, most recently
from
bc00d91
to
f7709d1
Compare
carkod
force-pushed
the
fix-missing-arg
branch
from
f7709d1
to
0d890c4
Compare
carkod
force-pushed
the
fix-missing-arg
branch
5 times, most recently
from
20fffa1
to
3be4116
Compare
Previously not accumulating total amount of balance across all account. Also added fiat getter from dashaboard
carkod
force-pushed
the
fix-missing-arg
branch
from
3be4116
to
712a028
Compare
Move them down to Account class. This creates a "bubble" to hold the same calculation formula for future caching if necessary. On the other hand, every child that inherts Account and reuses the price_precision and qty_precision should override the value according to the symbol/pair. Following this line, e.g. Bots have different content for each instance, so symbol/pair changes every time. Deals, however, keep the same symbol for the whole transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.