Skip to content

Commit

Permalink
Merge pull request CrowdStrike#180 from carlosmmatos/minor-cleanups
Browse files Browse the repository at this point in the history
fix(aws): minor updates to sechub backend
  • Loading branch information
carlosmmatos authored May 22, 2024
2 parents b9ee3ef + a30904c commit fec2ab8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 18 deletions.
19 changes: 2 additions & 17 deletions docs/aws/manual/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,8 @@ This will be used to grant the EC2 instance access to the Security Hub and EC2 A

1. Navigate to the [IAM Roles](https://console.aws.amazon.com/iam/home#/roles) page
1. Click the **Create role** button
1. Select **Custom trust policy** and paste the following policy into the editor:

```json
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Principal": {
"Service": "ec2.amazonaws.com"
},
"Action": "sts:AssumeRole"
}
]
}
```

1. Select **AWS service** as the trusted entity
1. Select **EC2** as the service/use-case that will use this role
1. Click the **Next** button
1. Search for the policy you created in the previous step (e.g. `FIG-SecurityHub-Access-Policy`) and select it
1. Click the **Next** button
Expand Down
4 changes: 3 additions & 1 deletion fig/backends/aws/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ def __init__(self):
log.info("AWS Backend is enabled.")

def is_relevant(self, falcon_event):
return falcon_event.cloud_provider[:3].upper() == 'AWS'
if falcon_event.cloud_provider is not None:
return falcon_event.cloud_provider[:3].upper() == 'AWS'
return False

def process(self, falcon_event):
Submitter(falcon_event).submit()
Expand Down

0 comments on commit fec2ab8

Please sign in to comment.