Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-artifact version to v4 #2716

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/accessibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
# pa11y runs faster and produces smaller artifacts
# lighthouse includes performance tests and other checks for non-a11y best practices
# for now, just use pa11y as we focus on improving a11y specifically
package: ["pa11y"]
package: ["pa11y"]
fail-fast: false # don't cancel lighthouse job if pa11y fails, and vice versa
env:
AMY_DATABASE_HOST: localhost
AMY_DATABASE_PORT: 5432
AMY_DATABASE_NAME: test_amy
AMY_DATABASE_USER: postgres
AMY_DATABASE_PASSWORD: postgres
AMY_DATABASE_PASSWORD: postgres
AMY_INSTRUCTOR_RECRUITMENT_ENABLED: True

services:
Expand All @@ -40,7 +40,7 @@ jobs:
--health-retries 5
ports:
- 5432:5432

steps:

# Database setup
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:

- name: run Lighthouse CI
run: |
npm install -g @lhci/[email protected]
npm install -g @lhci/[email protected]
npm install -g puppeteer
lhci autorun
env:
Expand All @@ -109,7 +109,7 @@ jobs:
if: matrix.package == 'lighthouse'

# Pa11y

- name: Start server in background
run: |
pipenv run make serve &
Expand All @@ -123,7 +123,7 @@ jobs:
continue-on-error: true

- name: Upload pa11y test results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pa11y-ci-report
path: pa11y-ci-report/
Expand Down
Loading