Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EBS cleanup job typo #1135

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix EBS cleanup job typo #1135

wants to merge 2 commits into from

Conversation

achantavy
Copy link
Contributor

@achantavy achantavy commented Mar 14, 2023

Fix: changes EBS volume cleanup job from ATTACHED_TO => ATTACHED_TO_EC2_INSTANCE.


This is already annotated in docs here as ATTACHED_TO_EC2_INSTANCE: https://github.com/lyft/cartography/blob/master/docs/root/modules/aws/schema.md#relationships-69

and this is created in the code itself as ATTACHED_TO_EC2_INSTANCE: https://github.com/lyft/cartography/blob/2903dbe5693efe43dcd578397ef2d864571d5946/cartography/intel/aws/ec2/volumes.py#L82

So the cleanup job here is wrong.

@achantavy achantavy removed the request for review from ramonpetgrave64 March 14, 2023 20:36
@achantavy achantavy marked this pull request as draft March 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant