Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #689: correctly pass job name to GraphStatement #1355

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

achantavy
Copy link
Contributor

Summary

Describe your changes.

Fixes job name not being correctly passed to the graph statement from the data model.

Checklist

Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:

  • Include console log trace showing what happened before and after your changes.

Before

INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.job:Finished job EMRCluster
INFO:cartography.intel.aws.inspector:Running AWS Inspector cleanup
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.job:Finished job AWSInspectorFinding
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.statement:Completed None statement #None
INFO:cartography.graph.job:Finished job AWSInspectorPackage

After

INFO:cartography.graph.statement:Completed EMRCluster statement #1
INFO:cartography.graph.statement:Completed EMRCluster statement #2
INFO:cartography.graph.job:Finished job EMRCluster
INFO:cartography.intel.aws.inspector:Running AWS Inspector cleanup
INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #1
INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #2
INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #3
INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #4
INFO:cartography.graph.statement:Completed AWSInspectorFinding statement #5
INFO:cartography.graph.job:Finished job AWSInspectorFinding
INFO:cartography.graph.statement:Completed AWSInspectorPackage statement #1
INFO:cartography.graph.statement:Completed AWSInspectorPackage statement #2
INFO:cartography.graph.statement:Completed AWSInspectorPackage statement #3
INFO:cartography.graph.job:Finished job AWSInspectorPackage

@achantavy achantavy merged commit c9500db into master Sep 18, 2024
7 checks passed
@achantavy achantavy deleted the fixnonestatements branch September 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants