Merge pull request #405 from vmware-tanzu/perf-enhancement-394

Use memoization to reduce api calls to get list of ResourceTypes
carvel-dev · Jan 7, 2022 · dfb5fca · dfb5fca
2 parents e3b47f5 + a1a1c66
commit dfb5fca
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/kapp/resources/resource_types.go b/pkg/kapp/resources/resource_types.go
@@ -46,6 +46,10 @@ func NewResourceTypesImpl(coreClient kubernetes.Interface, opts ResourceTypesImp
 }
 
 func (g *ResourceTypesImpl) All() ([]ResourceType, error) {
+	return g.memoizedAll()
+}
+
+func (g *ResourceTypesImpl) all() ([]ResourceType, error) {
 	serverResources, err := g.serverResources()
 	if err != nil {
 		return nil, err
@@ -141,7 +145,7 @@ func (g *ResourceTypesImpl) memoizedAll() ([]ResourceType, error) {
 	g.memoizedResTypesLock.Lock()
 	defer g.memoizedResTypesLock.Unlock()
 
-	resTypes, err := g.All()
+	resTypes, err := g.all()
 	if err != nil {
 		return nil, err
 	}