Github Picker is not taking into account the color parameter #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color controls what color is active on the color picker and according to documentation should be available for all the color pickers, but for the github picker it wasn't working. Fixed this and added an example too.
|
Hi @casesandberg , could you have a look at this PR and hopefully merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Picker is not taking into account the color parameter but according to documentation it should be available for all the color pickers. I fixed this and added an example for it to the project.
Current behavior: after choosing a color and closing the color picker, when opening it again there is no active color:
After fix: after choosing a color and closing the color picker, when opening it again the active color is shown:
