Added MintInfo Class #209
Open
Added MintInfo Class #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnuf
reviewed
Nov 18, 2024
gudnuf
reviewed
Nov 18, 2024
src/model/MintInfo.ts
Outdated
| import { GetInfoResponse, MPPMethod, SwapMethod, WebSocketSupport } from './types'; | ||
|
|
||
| export class MintInfo { | ||
| private readonly mintInfo: GetInfoResponse; |
There was a problem hiding this comment.
should we use _mintInfo to match other private fields?
gudnuf
approved these changes
Nov 18, 2024
lollerfirst
reviewed
Nov 18, 2024
| isSupported(num: 17): { supported: boolean; params?: Array<WebSocketSupport> }; | ||
| isSupported(num: 15): { supported: boolean; params?: Array<MPPMethod> }; | ||
| isSupported(num: number) { | ||
| switch (num) { |
There was a problem hiding this comment.
Should the cases be handled exhaustively so that unrecognized NUT numbers always resolve to false?
Or alternatively throw on unrecognized NUT number.
There was a problem hiding this comment.
Very good point! I added a default case that throws. Throwing in this case makes more sense to me, because it makes clear that this NUT is unsupported by the client, not the mint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a MintInfo class that exposes some helper methods to easily check if a mint supports a NUT.
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format