-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): throwing weapons sanity-checking #5474
base: main
Are you sure you want to change the base?
Conversation
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
So, throwing rocks at 12 in stats and 10 throwing skill deals about 12 damage prior to this change, and about 19 with the change. I'm trying to figure out where I bungled the math in the process of writing this. |
Okay, tests pass after giving it a second look, and new testing done:
So it seems Scarf did succeed in fixing the damage values, it's just the UI is displaying them very wrongly for some reason. |
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
followup of #5088.
Scarf said to just PR this as a draft to look at. WIP because this fucking nonsense is producing wildly different results despite seemingly near-identical input:
Also the item.cpp version of the function is fucking up and adding the weight of the weapon the ammo is loaded into, but we're not even remotely close to fixing that fuckery just yet.
Describe the solution
Describe alternatives you've considered
Testing
Additional context