Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): also capitalize spell name for Spellcraft #5528

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

Tiny followup to #5523

Describe the solution

Capitalized skill name of spellcraft in Magiclysm. Bonus dose of {}ifying the name like vanilla skills.

Describe alternatives you've considered

Punishing it with lowercase skill name for its crimes.

Testing

Used my eyes.

Additional context

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Oct 6, 2024
@chaosvolt chaosvolt enabled auto-merge (squash) October 6, 2024 21:20
@RoyalFox2140
Copy link
Collaborator

I should've checked mods. Whoops

@chaosvolt chaosvolt merged commit e4f1638 into cataclysmbnteam:main Oct 6, 2024
9 checks passed
@chaosvolt chaosvolt deleted the tiny-lil-skillfix branch October 6, 2024 22:15
@Proxiehunter
Copy link

I should've checked mods. Whoops

Speaking of mods, was the Arcana skill from the Arcana mod included?

@RoyalFox2140
Copy link
Collaborator

I should've checked mods. Whoops

Speaking of mods, was the Arcana skill from the Arcana mod included?

It's not in repo, use the issue template on Arcana's repo if it wasn't.

@chaosvolt
Copy link
Member Author

Speaking of mods, was the Arcana skill from the Arcana mod included?

I fixed Arcana in this commit: chaosvolt/cdda-arcana-mod@7269ee6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants