Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use C++20 string::{starts,ends}_with #5535

Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 8, 2024

Checklist

Required

Purpose of change

code is liability; replace them with functions available in C++20 stdlib since we have #5514

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@scarf005 scarf005 changed the title refactor: use string::{starts,ends}_with refactor: use C++20 string::{starts,ends}_with Oct 8, 2024
@github-actions github-actions bot added src changes related to source code. tests changes related to tests labels Oct 8, 2024
@OrenAudeles
Copy link
Collaborator

looks good to me

@scarf005 scarf005 merged commit 01bfa37 into cataclysmbnteam:main Oct 8, 2024
12 checks passed
@scarf005 scarf005 deleted the refactor/c++20-string-methods branch October 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code. tests changes related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants