Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use concepts even more #5538

Merged

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 8, 2024

Checklist

Required

Purpose of change

followup to #5537: apply https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-constraints.html

Describe the solution

ran:

$ parallel ./build-scripts/clang-tidy-wrapper.sh {} -fix '--checks=-\*,modernize-use-constraints,modernize-type-traits' ::: src/*.{cpp,h}

btw it took 370s lol

Testing

should (probably) build

@github-actions github-actions bot added the src changes related to source code. label Oct 8, 2024
@scarf005 scarf005 force-pushed the refactor/use-concepts-automated branch from e51c14c to a5acaa8 Compare October 8, 2024 16:48
@OrenAudeles
Copy link
Collaborator

a few build errors on this one still :(

@scarf005 scarf005 force-pushed the refactor/use-concepts-automated branch 3 times, most recently from b6970e0 to a3c18af Compare October 8, 2024 17:07
@cataclysmbnteam cataclysmbnteam deleted a comment from autofix-ci bot Oct 8, 2024
@scarf005 scarf005 force-pushed the refactor/use-concepts-automated branch from a3c18af to bb6af8c Compare October 8, 2024 17:44
Copy link
Collaborator

@OrenAudeles OrenAudeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a pretty big PR, but thankfully wasn't doing anything weird. It was easy to see why the changes were being made blah<T>::type to blah_t<T> and blah<T>::value to blah_v<T> mostly, along with changing over from enable_if to requires syntax

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot to go over but it compiles and loads, and only tests that're failing are clang whining about unrelated things again: https://github.com/cataclysmbnteam/Cataclysm-BN/actions/runs/11241032936/job/31251730123?pr=5538

@scarf005 scarf005 force-pushed the refactor/use-concepts-automated branch from b535e4c to 7eab273 Compare October 9, 2024 01:03
@scarf005 scarf005 merged commit 58e6e61 into cataclysmbnteam:main Oct 9, 2024
11 checks passed
@scarf005 scarf005 deleted the refactor/use-concepts-automated branch October 9, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants