Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop muscle engines failing sounding like a V8 #5569

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

RobbieNeko
Copy link
Contributor

@RobbieNeko RobbieNeko commented Oct 12, 2024

Checklist

Required

Purpose of change

As noted in the Discord, the engine fail noise for non-battery engines was a clanking noise that generally sounds more appropriate for a v8 than a foot pedal in most soundpacks. This fix silences these woes.

Describe the solution

Modify the check to also make sure the engine isn't muscle-powered

Describe alternatives you've considered

  • Wait for KorG or someone similar to make a better fix / JSONize everything
  • Meme on foot pedals secretly being incredibly tiny v8 engines

Testing

None, it's an if statement logic change.

Additional context

This doesn't cause a regression in notice of a bike failing to start for non-soundpack players because it didn't print a failure message in the first place. Also, how often is a bike in such bad footpedal condition without basically being in pieces anyway?

@github-actions github-actions bot added the src changes related to source code. label Oct 12, 2024
Copy link
Contributor

autofix-ci bot commented Oct 12, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@chaosvolt chaosvolt merged commit 663ec9b into cataclysmbnteam:main Oct 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants