Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Change floodlight symbol to 'T' #5571

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

Soadreqm
Copy link
Contributor

Checklist

Required

Optional

Purpose of change

Grid floodlight symbol was difficult to see on a floor when using ASCII graphics.

Describe the solution

Changed symbol of f_grid_floodlight (all variants) from . to T, same as the floor lamp. Also changed the "on" state color from white to yellow, to provide a visual indicator that the floodlight is active.

Describe alternatives you've considered

The t_utility_light that appears in labs has the same issue, being basically invisible on a concrete floor, but I think it's less of a problem there. They don't use grid power, so there's rarely any reason to turn them off.

Testing

Looked at a built floodlight, turned it on and off.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 13, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presumably copypasted it from utility light terrain, where it being a . sorta made sense because it had zero impact as an obstacle and was basically just a floor but bright. Thanks for spotting that!

@chaosvolt chaosvolt merged commit 0f185af into cataclysmbnteam:main Oct 13, 2024
9 checks passed
@Soadreqm Soadreqm deleted the floodsprite branch October 13, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants