Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(port,content): Winged zombies #5586

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Zlorthishen
Copy link
Contributor

Checklist

Required

Optional

Purpose of change

ports

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Zlorthishen and others added 2 commits October 17, 2024 22:26
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Oct 19, 2024
Copy link
Contributor

autofix-ci bot commented Oct 19, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Zlorthishen Zlorthishen marked this pull request as draft October 19, 2024 01:43
@Zlorthishen Zlorthishen marked this pull request as ready for review October 19, 2024 16:33
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks aight, they no longer spawn next to the player which was if I recall what killed the port the first time.

These flags would be good to have to make it not make explosion noises and show a visual explosion effect though.

data/json/monster_special_attacks/spells.json Outdated Show resolved Hide resolved
data/json/monster_special_attacks/spells.json Outdated Show resolved Hide resolved
data/json/monster_special_attacks/spells.json Outdated Show resolved Hide resolved
data/json/monster_special_attacks/spells.json Outdated Show resolved Hide resolved
chaosvolt
chaosvolt previously approved these changes Oct 23, 2024
@chaosvolt
Copy link
Member

Wait, is it intentional that they can't actually fly? o.O

@chaosvolt chaosvolt dismissed their stale review October 23, 2024 02:11

Some issues found

Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, some issues with this I spotted a bit belatedly:

  1. Winged zombies and garghouls can't fly, only flesh raptors can. I guess that makes sense if you're being realismic, but a side effect of that is that winged zombies and garghouls don't really have any reason to exist. But funny thing about that...
  2. That's the neat part, they don't! Crawlers were given pupas as evolutions so those will spawn, but batwing zombies and garghouls don't have any spawns or evolution connections.

I'd say give winged zombies monstergroup inclusions with a starts delay of about 500, since they're potentially bigger and beefier than flesh raptors that have a half-life of 14 (which should work out to 336 hours), but in exchange add FLIES to them and garghouls, and adjust descriptions where needed.

Zlorthishen and others added 5 commits October 22, 2024 21:23
added `FLIES` and `HIT_AND_RUN`
added winged zombies to `GROUP_ROOF_ZOMBIES`
added a few more locations and `starts:500`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants