fix: clang-tidy-wrapper's c++ fixes #5599
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
Better code practices are nice, and this will hopefully prevent yelling at us by clang in the future.
Describe the solution
Uses the included script by Scarf that acts as a wrapper for clang-tidy
Describe alternatives you've considered
The script itself seemed to have some bugs (I had to change which flag it was using to tell it to fix the bugs for one, but it also complained about some missing files). However, any improvement is good
Testing
I hope clang-tidy isn't going to break anything, or else we've got some very bad news for the project as a whole.
Additional context
Thanks for RoyalFox asking me to run the script in the first place
Feel free to update the semantic title category as needed
Updated run command for the script:
$ parallel ./build-scripts/clang-tidy-wrapper.sh {} -fix-errors ::: src/*.{c,h}