Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: armor penetration for melee weapons [WIP] #5600

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Soadreqm
Copy link
Contributor

Checklist

Required

Optional

Purpose of change

The game supports armour penetration values for attacks, both flat and percentage. These were actually possible to define for melee weapons, but weren't considered in the melee weapon damage rolls.

I'm not sure if it's really a good idea to add armour penetration to real items, but it's still nice to have the functionality.

Describe the solution

So far I've just added a couple helper functions to damage_instance to get the armour modifiers, and checked them in melee attacks. The numbers aren't correctly displayed when examining an item, but from initial testing they're clearly doing something

Describe alternatives you've considered

Testing

Use the provided chaos dagger.

Additional context

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. labels Oct 22, 2024
Copy link
Contributor

autofix-ci bot commented Oct 22, 2024

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@Soadreqm Soadreqm marked this pull request as draft October 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant